feat(FR-2833): show deployment ID and use BooleanTag for public access#7285
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment detail UI to surface an ID next to the deployment name, replace the OpenToPublic icon indicator with a BooleanTag, and align field ordering between the overview and the settings modal. It also adds i18n entries needed for the new label/checkbox text.
Changes:
- Deployment overview: show deployment name as copyable text and display an ID next to it; reorder overview items so DesiredReplicas appears before Tags.
- OpenToPublic indicator: replace check/close icons with
BooleanTag. - Deployment settings modal: reorder fields (Name → Replicas → Tags → OpenToPublic) and add a labeled OpenToPublic checkbox using new i18n keys.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/components/DeploymentConfigurationSection.tsx | Adds ID display next to name, switches OpenToPublic to BooleanTag, reorders overview fields, and fetches deployment id. |
| react/src/components/DeploymentSettingModal.tsx | Reorders form items and adds a labeled OpenToPublic checkbox with localized “Public” text. |
| resources/i18n/en.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/ko.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/de.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/el.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/es.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/fi.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/fr.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/id.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/it.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/ja.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/mn.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/ms.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/pl.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/pt.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/pt-BR.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/ru.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/th.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/tr.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/vi.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/zh-CN.json | Adds deployment.Public and general.ID strings. |
| resources/i18n/zh-TW.json | Adds deployment.Public and general.ID strings. |
Merge activity
|
#7285) Resolves #7284 ([FR-2833](https://lablup.atlassian.net/browse/FR-2833)) ## Summary - Display deployment global ID via `BAIId` next to the deployment name in the overview, with the name shown via copyable `BAIText`. - Replace `CheckOutlined`/`CloseOutlined` icons with `BooleanTag` for the OpenToPublic field for a consistent, color-coded boolean indicator. - Reorder overview fields so DesiredReplicas appears before Tags, matching the modal order. - In `DeploymentSettingModal`, reorder fields (Name → Replicas → Tags → OpenToPublic) and give the OpenToPublic form item a proper label with a localized "Public" checkbox text. - Add `general.ID` and `deployment.Public` i18n keys across all 22 supported languages. ## Test plan - [ ] Open a deployment detail page; verify the overview shows the deployment name (copyable) followed by its global ID. - [ ] Verify OpenToPublic renders as a `BooleanTag` instead of an icon. - [ ] Verify field order in the overview: Name (ID) → Project → Domain → EndpointUrl → OpenToPublic → DesiredReplicas → Tags. - [ ] Open the deployment Setting modal; verify field order: Name → Replicas → Tags → OpenToPublic with a "Public" label/checkbox. - [ ] Verify both new i18n keys render in English and Korean (and at least one other language). [FR-2833]: https://lablup.atlassian.net/browse/FR-2833?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
787ff44 to
816b172
Compare
816b172 to
43b2147
Compare

Resolves #7284 (FR-2833)
Summary
BAIId(decoded local UUID) next to the deployment name in the overview, with the name shown via copyableBAIText.CheckOutlined/CloseOutlinedicons withBooleanTagfor the OpenToPublic field, with localizedYes/Nolabels and a-fallback when the value is missing.DeploymentSettingModal, reorder fields (Name → Replicas → Tags → OpenToPublic) and give the OpenToPublic form item a proper label with a localized "Public" checkbox text.general.ID,deployment.Public, anddeployment.NameAndIDi18n keys across all 22 supported languages (single combined key replaces concatenated label).Test plan
BooleanTag(Yes/No) instead of an icon, and shows-while loading.